frontend: Add float support - #1049
Conversation
bbdff3a to
e5bd690
Compare
Jozott00
left a comment
Jozott00
left a comment
There was a problem hiding this comment.
VIAM side looks good! (just the copy/paste error)
I would like to leave the frontend review to @flofriday
| public void verify() { | ||
| super.verify(); | ||
| // FIXME: for now this is checked here, but this should create a diagnostic instead of ViamError | ||
| ensure(encoding != null, "Encoding not specified"); |
There was a problem hiding this comment.
This is checked by the annotation right? So it should be fine to have it as a safe guard ViamError here.
There was a problem hiding this comment.
If no annotation is present, then the encoding is missing, which should lead to a diagnostic error. I am not sure how the absence of an annotation should be checked.
|
I'm still on vacation till Saturday (in the woods without any laptop) so this review will take until the end of the week. Thanks for including me @Jozott00 😊 |
- Adds float-type definition - Adds annotation [ IEEE : <size> ] for float-type - Adds annotation [ [sticky] fe flag <flag-name> : <format-field> ] for registers - Adds new syntax for SymbolExpr: id::path::<const params>(params) - Adds new VIAM nodes and built-in types - FloatFormat node - Constant.FloatType - VIAM annotation for float exception flags - The built-in type FloatType, which is the type of FloatFormat - Adds constant-param-based type inference and checking for built-ins
e5bd690 to
c39a8b1
Compare
|
@flofriday please take a look at #578 (comment) before the review, as it explains the intention behind this PR and the open problem with the new syntax. Thanks! |
3 participants
[ IEEE : <size> ]for float-type[ [sticky] fe flag <flag-name> : <format-field> ]for registersid::path::<const params>(params)